[Bug 65131] Gabble 0.17.3 does not interoperate with GMail web UI

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=65131

--- Comment #13 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Created attachment 80196
  --> https://bugs.freedesktop.org/attachment.cgi?id=80196&action=edit
WockyJingleFactory: ref session while calling parse()

wocky_jingle_session_parse() advances the session's state
machine. In particular, it may cause termination, which
causes the session to be removed from the factory's
hash table, which may cause its last ref to be released.

Until recently, this would have gone unnoticed, but
wocky_jingle_session_acknowledge_iq() now emits a signal
from the session (to check whether it has the "is Google
webmail" quirk), and that causes a check that it is in fact
still a valid session object.

Also correct a misleading comment spotted while debugging
this: priv->sessions owns both key and sess.

---

Unfortunately, the patches I already merged for this caused a regression, which
I caught while trying to make Gabble's tests a little more reliable. This seems
to fix it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.