[Bug 61792] examples/wocky-dump-certificates doesn't have TLS_CFLAGS / TLS_LIBS in Makefile

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Mar 15 21:01:17 CET 2013


https://bugs.freedesktop.org/show_bug.cgi?id=61792

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 76588
  --> https://bugs.freedesktop.org/attachment.cgi?id=76588
Patch for wocky

Review of attachment 76588:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=61792&attachment=76588)
-----------------------------------------------------------------

I think it'd be better to set wocky_dump_certificates_LDADD to contain both
$(LDADD) and $(TLS_LIBS) (or @TLS_LIBS@ if you prefer) - the rest of the
examples don't use TLS code directly, so there's no point giving them a strong
dependency on it.

AM_CFLAGS ought to have $(TLS_CFLAGS) too, so it'll work if gnutls is not on
the compiler's default search path. That one doesn't really need to be
target-specific in the same way, since it won't alter the code that gets
compiled/linked for the other examples - it can just go in AM_CFLAGS.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list