[Bug 57130] interactive TLS certificate verification

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=57130

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Coding style and other nitpicking
---------------------------------

Rather than whining about coding style, I just added patches...
http://cgit.freedesktop.org/~smcv/telepathy-idle/log/?h=interactive-tls

Non-issues
----------

+    g_async_queue_push (priv->certificate_queue, GINT_TO_POINTER (ret ? 
CERT_ACCEPTED : CERT_REJECTED));

It's a pity ::accept-certificate doesn't return a nullable GError - if it did,
we could pass a GError-or-NULL back to the thread rather than ignoring the
GError. This seems to be the best we can do, though...

    if (socket_connection != NULL)
-        g_task_return_pointer (task, socket_connection, g_object_unref);
+        g_simple_async_result_set_op_res_gpointer (task, socket_connection,
g_object_unref);
     else
-        g_task_return_error (task, error);
+        g_simple_async_result_take_error (task, error);

I was going to say "don't we need to g_simple_async_result_complete_in_idle()
here?"... but according to the g_simple_async_result_run_in_thread() docs, the
answer is "no" so never mind.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.