[Bug 64126] log-store-xml should use tp_account_get_normalized_name to get self_id.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=64126

--- Comment #3 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> ---
(In reply to comment #2)
> Maybe I'm overlooking something, but I feel that the correct fix is to trash
> that code actually. The best patches are patches that remove code :D

That will cause more harm then good. As said, the root of the problem is the
original design of the storage, information whould have been saved while it was
available. When you read back from the store, you can't assume that there is a
valid TpAccount for that data.

Long term solution is to drop that storage, and replace with a new one. Short
term, well you can't fixed the stored data really, so I don't see any magic
solution. But if the account exist, one would use 
tp_account_get_normalized_name(), and fallback to the current code when that
fails. That could be a good compromise and work in most cases. If the account
no longer exist, nobody will care how exact the id is.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.