[Bug 64837] New: Definition of TpCallStream::local-sending-state-changed is wrong

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=64837

          Priority: medium
            Bug ID: 64837
          Assignee: telepathy-bugs at lists.freedesktop.org
           Summary: Definition of
                    TpCallStream::local-sending-state-changed is wrong
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: otaylor at redhat.com
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: tp-glib
           Product: Telepathy

Currently unless you disable fatal warnings, the build of telepathy-glib fails
because the docs for TpCallStream::local-sending-state-changed don't match the
signal definition. It turns out that the signal definition itself is wrong:

  /**
   * TpCallStream::local-sending-state-changed:
   * @self: the #TpCallStream
   * @state: the new #TpSendingState
   * @reason: the #TpCallStateReason for the change
   *
   * The ::local-sending-state-changed signal is emitted whenever the
   * stream sending state changes.
   *
   * Since: 0.17.5
   */
  _signals[LOCAL_SENDING_STATE_CHANGED] = g_signal_new
("local-sending-state-changed",
      G_OBJECT_CLASS_TYPE (klass),
      G_SIGNAL_RUN_LAST,
      0, NULL, NULL, NULL,
      G_TYPE_NONE,
      4, G_TYPE_UINT, G_TYPE_UINT, TP_TYPE_CALL_STATE_REASON,
      G_TYPE_HASH_TABLE);

The docs have two parameters, the signal definition 4 parameters, and when
emitted:

  g_signal_emit (self, _signals[LOCAL_SENDING_STATE_CHANGED], 0,
      self->priv->local_sending_state, r);

2 again. I'm surprised this isn't causing crashes - most likely this code never
gets hit.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.