[Bug 69430] Make NewChannels, etc., singular?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69430

--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #3)
> Created attachment 88630 [details]
> [02/12] Flatten Requests interface into Connection
> 
> ---
> 
> Fixes Bug #50093. Commit message needs amending to say so.

This might actually not be such a great idea. EnsureChannel and CreateChannel
should clearly be core, and RequestableChannelClasses (aka
TP_CONNECTION_FEATURE_CAPABILITIES) can reasonably be core while connected, but
Channels (and its change-notification, NewChannel(s) and ChannelClosed) are
sufficiently special-purpose that I think only the AM and regression tests
should be using it. Having the Channels and their immutable properties in the
GetAll result seems non-optimal.

I'm tempted to revise this plan to:

* move EnsureChannel, CreateChannel, RequestableChannelClasses to Connection

* rename the rest of Requests to ChannelList

* keep ChannelList mandatory

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.