[Bug 71384] improve account storage GInterface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=71384

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #7)
> > This would have been easier to review if you added the default
> > implementations in a commit where you weren't deleting anything.
> 
> Right, I failed at doing proper git commits, sorry. When refactoring I see
> more stuff to change on the way and I end up with a mess to commit. But now
> that you reviewed it already, is it ok with you to keep it like that?

Yes, it's OK now, but be careful in future :-)

(I often rebase refactoring branches several times before publishing.)

> > While you're breaking API anyway, I would be very tempted to turn
> > commit[_one]() into an async/finish pair (Bug #29563), even if all its call
> > sites initially just call it with a no-op callback and hope it worked.
> 
> Let's keep that out-of-scope here, but indeed bug #29563 can follow once
> this lands.

OK.

> > This calling convention is also pretty insane - McdStorageAccount should be
> > a simple "view" of the plugin, and not have any storage of its own - but I
> > think fixing that is out of scope right now. I might do a follow-up branch
> > to do that before 5.17, though.
> 
> please open a new bug for that idea.

Sure.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.