[Bug 71384] improve account storage GInterface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=71384

--- Comment #17 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to comment #16)
> > + PARAM ("param-modem", path);
> 
> Use the modem's object path as the StorageIdentifier, maybe?

done.

> + g_hash_table_insert (modem->attributes,
> + "org.freedesktop.Telepathy.Account.Interface.Addressing.URISchemes",
> + g_variant_ref_sink (g_variant_new_strv (&uri_scheme, 1)));
> 
> My understanding had been that URISchemes is for "secondary" URI schemes,
> and that a telephony UI should use this pseudocode:
> 
>     if account.protocol_name == "tel" or account.use_for("tel"):
>         add_button("Call using %s" % account, account)
> 
> Otherwise, a telephony account without "tel" in URISchemes would be
> completely useless...

ok, removed it.

> + variant = g_hash_table_lookup (modem->properties, "Powered");
> + if (variant != NULL)
> + return g_variant_get_boolean (variant);
> 
> Don't be remotely crashable:
> 
> if (variant != NULL && g_variant_classify (variant) ==
> G_VARIANT_CLASS_BOOLEAN)
> 
> or equivalent.
> 
> Or you could use tp_vardict_get_boolean().
> 
> + if (g_str_equal (property, "Powered"))
> + {
> + mcp_account_storage_emit_toggled ((McpAccountStorage *) self,
> + modem->account_name, g_variant_get_boolean (value));
> + }
> 
> Likewise.

It needs to be for for all g_variant_get then for being really pedantic. Done.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.