[Bug 27727] account storage plugins can contain partial accounts

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Nov 14 11:46:57 PST 2013


https://bugs.freedesktop.org/show_bug.cgi?id=27727

--- Comment #34 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to comment #20)
> Created attachment 89223 [details] [review]
> 16/26] Make account deletion async (sort of), and imply a  selective commit
> 
> This means we don't need to commit separately after each deletion,
> and means account plugins don't have to have the concept of flagging
> an account for "delete this later" - much rejoicing.
> 
> It also has the incidental benefit that we no longer use the C++
> reserved word 'delete' in a header file.

mcp_account_storage_delete_finish()'s doc should tell about the default
implementation. Do we recommend to override _finish() when _async is overriden,
or can we state that if _async is implemented using GTask then the default
_finish is good? I can guess your answer on this, but better to say it
explicitly in the doc, no?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the telepathy-bugs mailing list