[Bug 69885] MC tests don't simulate Contacts interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69885

--- Comment #11 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Created attachment 86932
  --> https://bugs.freedesktop.org/attachment.cgi?id=86932&action=edit
11/11] McdAccount: go back to using GetKnownAvatarTokens

Sadly, contact attributes aren't enough to distinguish between
"this protocol doesn't store avatars and you haven't re-sent your
avatar since you last connected", "this protocol stores avatars but
the CM hasn't checked for your current avatar yet", and "this protocol
stores avatars, but there is no avatar on the server for you".

GetKnownAvatarTokens specifically excludes the middle option (blocking
on a server round-trip if it needs to), and uses "avatar token missing"
for the first and "avatar token empty" for the last.

---

Avatars1 (Bug #55920) will fix this hopelessly subtle logic, hopefully...

Next time I design an API where NULL/omission and the empty string are both
allowed, and mean different things, please remind me how long this bug took to
fix. :-)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.