[Bug 70078] Gabble: pre next clean up

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70078

--- Comment #20 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #19)
> Comment on attachment 87107 [details] [review]
> test-roster-subscribe: stop testing old API
> 
> Review of attachment 87107 [details] [review]:
> -----------------------------------------------------------------
> 
> Possibly wrong, but not a regression:
> 
> ::: tests/twisted/roster/test-roster-subscribe.py
> @@ +19,3 @@
> >  
> >  def test_modern_reject(q, bus, conn, stream):
> > +    test(q, bus, conn, stream, 'reject')
> 
> It looks as though this should maybe have said (... stream, True, False,
> 'reject')? Does it still pass if you change it to  (... stream, False,
> 'reject')?

It does.
But changing:

def test_modern_revoke(q, bus, conn, stream):
-    test(q, bus, conn, stream, 'revoke')
+    test(q, bus, conn, stream, False, 'revoke')

doesn't pass.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.