[Bug 70434] Idle: add IrcCommand extension

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70434

--- Comment #16 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 87625
  --> https://bugs.freedesktop.org/attachment.cgi?id=87625
IRC_Command: remove possible errors

Review of attachment 87625:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=70434&attachment=87625)
-----------------------------------------------------------------

::: extensions/Connection_Interface_IRC_Command1.xml
@@ -31,4 @@
>          <p>Send an arbitrary IRC command to the server.</p>
>        </tp:docstring>
>        <tp:possible-errors>
> -        <tp:error name="org.freedesktop.Telepathy.Error.Disconnected"/>

Disconnected is perfectly reasonable. IRCCommand1.Send shouldn't work until
we're connected.

@@ -31,5 @@
>          <p>Send an arbitrary IRC command to the server.</p>
>        </tp:docstring>
>        <tp:possible-errors>
> -        <tp:error name="org.freedesktop.Telepathy.Error.Disconnected"/>
> -        <tp:error name="org.freedesktop.Telepathy.Error.NetworkError"/>

Also perfectly reasonable.

@@ -34,5 @@
> -        <tp:error name="org.freedesktop.Telepathy.Error.Disconnected"/>
> -        <tp:error name="org.freedesktop.Telepathy.Error.NetworkError"/>
> -        <tp:error name="org.freedesktop.Telepathy.Error.NotAvailable"/>
> -        <tp:error name="org.freedesktop.Telepathy.Error.InvalidArgument"/>
> -        <tp:error name="org.freedesktop.Telepathy.Error.PermissionDenied"/>

Removing these three is fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.