[Bug 34640] Use Protocol.IdentifyAccount to choose accounts' object paths

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34640

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 87680
  --> https://bugs.freedesktop.org/attachment.cgi?id=87680
Don't give storage plugins the full parameter set, just  'account'

Review of attachment 87680:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=34640&attachment=87680)
-----------------------------------------------------------------

::: mission-control-plugins/account.c
@@ +287,4 @@
>   * MC has not previously seen before (ie one created by a 3rd party
>   * in the back-end that the plugin in question provides an interface to).
>   *
> + * Changed in 5.17: instead of a map from string to GValue, the last

Yeah in principle this should have been 5.UNRELEASED, but if we can't get this
merged before we next stable-branch, then we're not trying hard enough.

::: src/mcd-account-manager-sso.c
@@ +971,5 @@
>        g_hash_table_insert (params, g_strdup (MC_ACCOUNT_KEY), &value);
>  
> +      /* FIXME: We should call IdentifyAccount(params) really. But this
> +       * plugin probably doesn't even compile any more, so, whatever;
> +       * just use the "account name". */

If people want to just delete this (pseudo-)plugin, I'd be in favour.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.