[Bug 70077] Gabble: port to tp-glib 0.99.2
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Wed Oct 16 04:07:54 PDT 2013
https://bugs.freedesktop.org/show_bug.cgi?id=70077
--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Ship it, and please tag it as 0.99.2 (then one or other of us can get on with
the giant sed invocation to have connection_interface_aliasing1, etc., in
generated C, for 0.99.3).
A couple of bits of cleanup which do not block merge:
> - if (!tp_handles_are_valid (handle_repo, contact_handles, FALSE, error))
> + if (!tp_handles_are_valid (handle_repo, contact_handles, FALSE, NULL))
> return NULL;
This is fine, but you could just g_return_val_if_fail, I think (please check in
telepathy-glib first but I'm pretty sure it guarantees not to call this with
bad handles).
> # pointless backwards compat section
> print >> f, '[ConnectionManager]'
>- print >> f, 'BusName=org.freedesktop.Telepathy.ConnectionManager.' + manager
>- print >> f, 'ObjectPath=/org/freedesktop/Telepathy/ConnectionManager/' + manager
>+ print >> f, 'BusName=im.telepathy1.ConnectionManager.' + manager
>+ print >> f, 'ObjectPath=/im/telepathy1/ConnectionManager/' + manager
We can delete this :-)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the telepathy-bugs
mailing list