[Bug 70077] Gabble: port to tp-glib 0.99.2

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Oct 16 10:08:46 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=70077

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #4)
> > > # pointless backwards compat section
> > > print >> f, '[ConnectionManager]'
> > >- print >> f, 'BusName=org.freedesktop.Telepathy.ConnectionManager.' + manager
> > >- print >> f, 'ObjectPath=/org/freedesktop/Telepathy/ConnectionManager/' + manager
> > >+ print >> f, 'BusName=im.telepathy1.ConnectionManager.' + manager
> > >+ print >> f, 'ObjectPath=/im/telepathy1/ConnectionManager/' + manager
> > 
> > We can delete this :-)
> 
> You mean we can remove the whole manager-file.py? Gabble doesn't seem to use
> it.

I meant the BusName and ObjectPath keys in the [ConnectionManager] group, which
are labelled "pointless backwards compat section" in the code I quoted :-)

> According to the comment, the master copy is in tp-glib. Should we drop it
> there as well?

Delete it from anywhere that doesn't use it? I think telepathy-glib uses it to
generate .manager files for the examples, so it will probably need to keep it.

The idea of using manager-file.py instead of write-mgr-file is that it's more
cross-compilation-friendly; but tbh we should probably just have a static
.manager file in the source tree, compile it in with GResource, and have a
TpBaseProtocol subclass that uses a GResource as its source data. Or
something...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list