[Bug 70626] Provide access to the user and host parts of RPL_WHOISUSER

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 18 23:33:40 CEST 2013


https://bugs.freedesktop.org/show_bug.cgi?id=70626

--- Comment #2 from Debarshi Ray <rishi.is at lostca.se> ---
Comment on attachment 87831
  --> https://bugs.freedesktop.org/attachment.cgi?id=87831
patch

Review of attachment 87831:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=70626&attachment=87831)
-----------------------------------------------------------------

::: src/idle-contact-info.c
@@ +455,5 @@
> +	_insert_contact_field(request->contact_info, "x-client-username", NULL, field_values);
> +
> +	name = g_value_get_string(g_value_array_get_nth(args, 2));
> +	field_values[0] = name;
> +	_insert_contact_field(request->contact_info, "x-client-hostname", NULL, field_values);

The x-client-hostname can also be a cloak on networks that have them. Given
that we already have a x-host field, maybe we should choose a different name? I
don't know.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list