[Bug 70377] [1.0] don't strip ABI versions from interface names

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70377

--- Comment #24 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 88221
  --> https://bugs.freedesktop.org/attachment.cgi?id=88221
[tp-fs] Adapt for use of ABI versions in generated code

Review of attachment 88221:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=70377&attachment=88221)
-----------------------------------------------------------------

Sure

::: examples/call-handler.c
@@ +578,4 @@
>  
>    tp_handle_channels_context_accept (handler_context);
>  
> +  tp_cli_channel_type_call1_call_accept (proxy, -1,

Certainly not a blocker, but shouldn't this be using
tp_call_channel_accept_async() since we have it?

@@ +632,5 @@
>    tp_base_client_add_handler_capabilities_varargs (client,
> +    TP_IFACE_CHANNEL_TYPE_CALL1 "/video/h264",
> +    TP_IFACE_CHANNEL_TYPE_CALL1 "/shm",
> +    TP_IFACE_CHANNEL_TYPE_CALL1 "/ice",
> +    TP_IFACE_CHANNEL_TYPE_CALL1 "/gtalk-p2p",

Not a blocker, but, tokens would be good.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.