[Bug 68758] Should watch systemd suspend signals

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=68758

--- Comment #4 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
Comment on attachment 85063
  --> https://bugs.freedesktop.org/attachment.cgi?id=85063
Listen to systemd sleep/shutdown signals, and inhibit until  disconnected

Review of attachment 85063:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=68758&attachment=85063)
-----------------------------------------------------------------

I guess systemd doesn't provide a client side helper lib for this?

::: src/connectivity-monitor.c
@@ +50,5 @@
> +#define LOGIN1_MANAGER_PREPARE_FOR_SHUTDOWN "PrepareForShutdown"
> +#define LOGIN1_MANAGER_INHIBIT "Inhibit"
> +
> +struct _McdInhibit {
> +    gsize holds;

Why are you using a gsize here? Also maybe document the semantic of 'holds'?

@@ +358,5 @@
> +
> +      if (sleeping)
> +        {
> +          DEBUG ("about to suspend");
> +          connectivity_monitor_change_states (self, 0, CONNECTIVITY_AWAKE,

Could be clearer to have a CONNECTIVITY_NONE or something rather than 0.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.