[Bug 55391] stop MC using things deprecated in 0.20

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Sep 11 03:03:18 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=55391

--- Comment #70 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #69)
> So I think in MC the right thing is the Close() the channel without caring
> about GROUP because - if I understand correctly - it is a fallback in the
> case there were no Handler or the Handler did not properly leave the channel
> itself. So it's not a normal code path that MC needs to leave the channel.

No, that's not what the "leave" code path is for. Closing undispatchable
channels uses Destroy(), falling back to Close().

The "leave" code path is for the benefit of plugins, specifically plugins that
dealt with StreamedMedia calls. For instance, the N900 UI only supported one
active call plus one call on hold (in any combination of protocols). If a third
StreamedMedia call came in, a MC plugin would insta-terminate it as Busy.

In modern Telepathy, calls should be Call1 channels, which have a HangUp()
method instead of (ab)using the Group interface. Accordingly, in Telepathy 1.0,
the "leave" code path is inappropriate and will just go away (see Bug #69176).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the telepathy-bugs mailing list