[Bug 37381] client-types.py appears to have a race

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37381

--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #5)
> As an example, the attached test/scenario will pass but I think it should
> not pass. It adds 10 resources online, and the client type will alternate
> between 'pc' and 'phone' while the resources are added. And removing one pc
> will make the client type change from 'pc' to 'phone' although there is
> still several pcs online.

If we used the same logic as resource_better_than(), the result of this test
would change to displaying the "dnd" presence of the most recent PC to come
online, ignoring the "available" phones. Would people prefer that?

Bug #32139 suggests that Sjoerd would prefer the "available" phones to be
preferred over the "dnd" PCs, which could be achieved by skipping the "strongly
prefer client type" step at the beginning of resource_better_than(), and adding
a "weakly prefer client type" step after comparing statuses. Where should that
go? Before "last available"? After "last available"? After priority? Answers on
a postcard.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.