[Bug 69216] Be able to run tests with recent automake

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Sep 11 06:25:23 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=69216

--- Comment #18 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 85626
  --> https://bugs.freedesktop.org/attachment.cgi?id=85626
configure: add AC_ARG_ENABLE(debug)

Review of attachment 85626:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=69216&attachment=85626)
-----------------------------------------------------------------

++ with comments:

::: configure.ac
@@ +89,4 @@
>     unused-parameter])
>  AC_SUBST([ERROR_CFLAGS])
>  
> +AC_ARG_ENABLE(debug,

[debug] would be better, but not very important

@@ +90,5 @@
>  AC_SUBST([ERROR_CFLAGS])
>  
> +AC_ARG_ENABLE(debug,
> +  AC_HELP_STRING([--disable-debug],[compile without debug code]),
> +    enable_debug=$enableval, enable_debug=yes )

Would be better as "[enable_debug=$enableval], [enable_debug=yes])" or even
"[], [enable_debug=yes])" although it isn't important.

(Look at the generated code - AC_ARG_ENABLE([foo]) always sets enable_foo in
the "user-specified" case anyway.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list