[Bug 69216] Be able to run tests with recent automake

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69216

--- Comment #20 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #17)
> Comment on attachment 85627 [details] [review]
> Run regression tests under the run-test.sh "driver"
> 
> Review of attachment 85627 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: tests/twisted/Makefile.am
> @@ +116,5 @@
> > +# ${pkglibexecdir}/tests is what GNOME's InstalledTests goal recommends.
> > +run-test.sh: run-test.sh.in Makefile
> > +	$(AM_V_GEN)sed \
> > +			-e 's![@]saluttestsdir[@]!${pkglibexecdir}/tests!' \
> > +			-e 's![@]TEST_PYTHON[@]!$(PYTHON)!' \
> 
> Replace with $(TEST_PYTHON) please? Other than that, ++

done.

In reply to comment #19)
> (In reply to comment #18)
> > > +AC_ARG_ENABLE(debug,
> > > +  AC_HELP_STRING([--disable-debug],[compile without debug code]),
> > > +    enable_debug=$enableval, enable_debug=yes )
> 
> Less misleading indentation would also be nice: enable_debug=... is at the
> same level as AC_HELP_STRING.
> 
> Strictly speaking, the whole AC_HELP_STRING call should also be inside [] to
> avoid underquoting:
> 
>     AC_ARG_ENABLE([debug],
>       [AC_HELP_STRING([--disable-debug], [compile without debug code])],
>       [], [enable_debug=yes])

changed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.