[Bug 69258] Fix Idle tests with recent automake

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Sep 12 04:15:30 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=69258

--- Comment #7 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #5)
> Comment on attachment 85697 [details] [review]
> Run regression tests under the run-test.sh "driver"
> 
> Review of attachment 85697 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: tests/twisted/Makefile.am
> @@ +37,5 @@
> > +config.py: Makefile
> > +	$(AM_V_GEN) { \
> > +		echo "PACKAGE_STRING = \"$(PACKAGE_STRING)\""; \
> > +		echo "PLUGINS_ENABLED = $(PLUGINS_ENABLED_PYBOOL)"; \
> > +	} > $@
> 
> What's this bit for? Is it copypasta from Gabble, or needed? It looks as
> though we didn't have a config.py before, and I'm pretty sure Idle doesn't
> actually have plugins.
> 
> (I wouldn't mind generating an empty config.py if you think it's useful to
> have the infrastructure ready for use, though.)

Yeah I copied the 'BUILT_SOURCES' section from Gabble which was generating a
config.py. I'll remove PLUGINS_ENABLED as it's indeed useless here and merge.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list