[Bug 69446] Potential race when generating gtypes (and more)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69446

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #0)
> set_file_contents() uses a predictable name for it's temporary file when
> writing atomically, and (at least) mission-control can hit a race in
> parallel builds. (https://bugzilla.yoctoproject.org/show_bug.cgi?id=5184)
> 
> Luckily this is known as telepathy-glib fixed these in
> 36c2a545c9c1d1cc6db205bfc33d980d29b0a0f6 so the same fixes need to be
> applied to mission-control.

Indeed. I thought I'd fixed this in all projects, but apparently I missed MC.

> (fwiw, I've also a proof-of-concept patch for the predicable name issue)

I don't think this is really a problem: we're writing to a user-controlled
directory, so we're not vulnerable to symlink attacks or anything. If we just
avoided the "generate the same file twice" anti-pattern, it'd be fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.