[Bug 69466] Haze: fix connection interfaces we claim to support

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 17 06:39:07 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=69466

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 85981
  --> https://bugs.freedesktop.org/attachment.cgi?id=85981
protocol: fix 'ConnectionInterfaces'

Review of attachment 85981:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=69466&attachment=85981)
-----------------------------------------------------------------

::: src/connection.c
@@ +140,5 @@
> +
> +    ifaces = g_ptr_array_new ();
> +    add_always_present_connection_interfaces (ifaces);
> +    add_optionnal_connection_interfaces (ifaces, prpl_info);
> +    g_ptr_array_add (ifaces, NULL);

Please either comment that it returns an array with NULL at the end, or just
return a (transfer full) gchar **. I think I'd prefer the latter.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list