[Bug 69466] Haze: fix connection interfaces we claim to support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69466

--- Comment #13 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #10)
> Comment on attachment 85981 [details] [review]
> protocol: fix 'ConnectionInterfaces'
> 
> Review of attachment 85981 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: src/connection.c
> @@ +140,5 @@
> > +
> > +    ifaces = g_ptr_array_new ();
> > +    add_always_present_connection_interfaces (ifaces);
> > +    add_optionnal_connection_interfaces (ifaces, prpl_info);
> > +    g_ptr_array_add (ifaces, NULL);
> 
> Please either comment that it returns an array with NULL at the end, or just
> return a (transfer full) gchar **. I think I'd prefer the latter.

Humm actually "(transfer full) gchar **" is annoying because
TpBaseConnection->get_interfaces_always_present is supposed to return a
(transfer container) GPtrArray while TpBaseProtocol->get_connection_details
returns a (transfer full) gchar **.

I'd like to reuse the same function for both so I'll go with the former option.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.