[Bug 19178] purple network callbacks don't work properly on Windows

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=19178

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 21312
  --> https://bugs.freedesktop.org/attachment.cgi?id=21312
Patch to fix the problem

Review of attachment 21312:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=19178&attachment=21312)
-----------------------------------------------------------------

::: src/main.c
@@ +106,5 @@
> +    static int use_glib_io_channel = -1;
> +        
> +    if (use_glib_io_channel == -1)
> +        use_glib_io_channel = (g_getenv("HAZE_GLIB_IO_CHANNEL") != NULL) ? 1 : 0;
> +#endif

If this is necessary to use Haze on Windows, why would you ever want to go back
to g_io_channel_unix_new()?

@@ +118,5 @@
>          cond |= PURPLE_GLIB_WRITE_COND;
>  
> +#ifdef _WIN32
> +        if (use_glib_io_channel == 0)
> +                channel = wpurple_g_io_channel_win32_new_socket(fd);

Does this do something that g_io_channel_win32_new_socket() doesn't?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.