[Bug 69466] Haze: fix connection interfaces we claim to support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69466

--- Comment #19 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 86039
  --> https://bugs.freedesktop.org/attachment.cgi?id=86039
85991: protocol: fix 'ConnectionInterfaces'

Review of attachment 86039:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=69466&attachment=86039)
-----------------------------------------------------------------

::: src/protocol.c
@@ +910,5 @@
> +      ifaces = haze_connection_dup_implemented_interfaces (
> +          self->priv->prpl_info);
> +      /* @connection_interfaces takes a NULL terminated (transfer full)
> +       * gchar ** so we have to dup each string and append NULL. */
> +      g_ptr_array_foreach (ifaces, (GFunc) g_strdup, NULL);

No, this copies the string, throws away the copy, and leaves the original in
the array. Use a "for" loop.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.