[Bug 31757] implement Proto.I.Avatars in Haze

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31757

--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 86040
  --> https://bugs.freedesktop.org/attachment.cgi?id=86040
protocol: claim that we implement Avatars

Review of attachment 86040:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=31757&attachment=86040)
-----------------------------------------------------------------

::: tests/twisted/cm/protocols.py
@@ +30,5 @@
>  
> +        # Protocol is supposed to implement Interface.Avatars iff the
> +        # connection implements Avatars as well.
> +        if cs.CONN_IFACE_AVATARS in flat_props['ConnectionInterfaces']:
> +            assertEquals([cs.PROTOCOL_IFACE_AVATARS], props[cs.PROTOCOL + '.Interfaces'])

OK, but you'll probably want to turn this into assertContains...

@@ +32,5 @@
> +        # connection implements Avatars as well.
> +        if cs.CONN_IFACE_AVATARS in flat_props['ConnectionInterfaces']:
> +            assertEquals([cs.PROTOCOL_IFACE_AVATARS], props[cs.PROTOCOL + '.Interfaces'])
> +        else:
> +            assertEquals([], props[cs.PROTOCOL + '.Interfaces'])

... and this into assertNotContains or whatever it's called.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.