[Bug 69715] logger: fix tests

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Sep 23 11:52:32 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=69715

--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 86372
  --> https://bugs.freedesktop.org/attachment.cgi?id=86372
sqlite: deal with g_date_time_new_from_unix_utc() failing

Review of attachment 86372:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=69715&attachment=86372)
-----------------------------------------------------------------

::: telepathy-logger/log-store-sqlite.c
@@ +329,4 @@
>    gchar *date;
>  
>    ts = g_date_time_new_from_unix_utc (tpl_event_get_timestamp (event));
> +  g_return_val_if_fail (ts != NULL, NULL);

Would it be better to return "9999-12-31" or something?

I'd be OK with declaring the answer to be "no" though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list