[Bug 69715] logger: fix tests

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69715

Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #7)
> Comment on attachment 86372 [details] [review]
> sqlite: deal with g_date_time_new_from_unix_utc() failing
> 
> Review of attachment 86372 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: telepathy-logger/log-store-sqlite.c
> @@ +329,4 @@
> >    gchar *date;
> >  
> >    ts = g_date_time_new_from_unix_utc (tpl_event_get_timestamp (event));
> > +  g_return_val_if_fail (ts != NULL, NULL);
> 
> Would it be better to return "9999-12-31" or something?
> 
> I'd be OK with declaring the answer to be "no" though.

I think that's fine. I spot this only because of the other bug I just fixed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.