[Bug 69629] [salut] port to tp-glib 0.99.1

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69629

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #1)
> > - IMPLEMENT (get_alias_flags);
> 
> Is the replacement property implemented?

Still needs doing?

> > - TpHandleRepoIface *repos[NUM_TP_HANDLE_TYPES])
> > + TpHandleRepoIface *repos[TP_NUM_HANDLE_TYPES])
> 
> Please sed this in master

done

> > + "message", G_TYPE_STRING, message,
> 
> This is going to crash if message is null, please copy the updated shim from
> wherever Guillaume committed it (Idle? tp-glib?) or double-check that
> message is never null

Still needs doing?

> Ugh, that hadn't occurred to me. We should probably change TpProtocol in
> next so it applies s/_/-/ when deriving the default icon name? :-(

done

> > +++ b/tests/twisted/constants.py
> 
> Please sync this from Gabble on master, so it uses PREFIX more and the
> resulting diff is less horrible.

done

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.