[Bug 69822] sync Gabble and MC servicetest, constants

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69822

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Created attachment 86583
  --> https://bugs.freedesktop.org/attachment.cgi?id=86583&action=edit
[MC master, 2/3] configure.ac: use AC_DEFINE instead of appending to  CFLAGS

In build systems that put CFLAGS in an environment variable rather
than a configure command-line argument (e.g. RPM, I think?), what we
put in CFLAGS will potentially take precedence, and the external
build system's chosen CFLAGS won't necessarily be used. Meanwhile,
if the build system puts CFLAGS on the make command line, it will
take precedence: in particular, debug logging could be disabled, which
is bad for debuggability. If we move to AC_DEFINE, they'll interact
properly.

There is one remaining use of CFLAGS in configure.ac, for code
coverage. RPMs and other production-quality builds shouldn't have
coverage instrumentation, so this doesn't really conflict.

Also use AS_IF instead of if/fi, while I'm touching these lines anyway:
it's better Autoconf style.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.