[Bug 69814] stop using the account id as a self id

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Sep 27 04:02:52 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=69814

--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 86714
  --> https://bugs.freedesktop.org/attachment.cgi?id=86714
add logger-test-helper.c

Review of attachment 86714:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=69814&attachment=86714)
-----------------------------------------------------------------

::: tests/lib/logger-test-helper.c
@@ +38,5 @@
> +
> +void
> +tpl_test_create_and_prepare_account (TpDBusDaemon *dbus,
> +    TpSimpleClientFactory *factory,
> +    GMainLoop *main_loop,

Possible refinement (non-review-blocker): if you used
tp_tests_proxy_run_until_prepared(), you wouldn't have to pass in a main loop
or have a callback, so your logic would be more linear (which is pretty useful
for regression tests, which want to be as clear as possible).

This is fine though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the telepathy-bugs mailing list