[Bug 69705] [1.0] Logger: port to tp-glib 0.99.1

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69705

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Comment on attachment 86726
  --> https://bugs.freedesktop.org/attachment.cgi?id=86726
move tp_tests_copy_dir() to logger-test-helper

Review of attachment 86726:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=69705&attachment=86726)
-----------------------------------------------------------------

::: tests/lib/logger-test-helper.c
@@ +69,5 @@
> +tp_tests_copy_dir (const gchar *from_dir, const gchar *to_dir)
> +{
> +  gchar *command;
> +
> +  // If destination directory exist erase it

We use /* */ comments, but this isn't a regression so never mind.

@@ +70,5 @@
> +{
> +  gchar *command;
> +
> +  // If destination directory exist erase it
> +  command = g_strdup_printf ("rm -rf %s", to_dir);

Ugh, horrible. But it's not a regression so yeah I suppose so. Hopefully we
don't call this on anything with shell metacharacters in?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.