[Bug 69705] [1.0] Logger: port to tp-glib 0.99.1

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=69705

--- Comment #18 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #17)
> For now, ship it. However, after that:

I just noticed that there is already an old 'next' branch upstream :\
http://cgit.freedesktop.org/telepathy/telepathy-logger/log/?h=next

I'd be tempted to just drop it and replace it with mine tbh.

> > -#define GSETTINGS_SCHEMA "org.freedesktop.Telepathy.Logger"
> > +#define GSETTINGS_SCHEMA "im.telepathy1.Logger"
> 
> We'll need a migration path for this later, but for now I think it's OK to
> have it be completely independent.

Actually do we really want to want that? The GSettings's schema path is
completely unrelated to the TP D-Bus namespace. Can't we just keep the current
schema as it?

> > + <interface name="im.telepathy1.Logger.DRAFT"
> 
> Please rename to im.telepathy1.Logger1 (or just Logger if we think it has
> the same level of stability as Account, but I doubt that) and copy it into
> telepathy-spec next.
> 
> > + namespace="...">FavouriteContactsIsReady</tp:dbus-ref> property.
> 
> Can we rename this to FavouriteContactsReady or FavouriteContactsAreReady so
> I don't get annoyed every time I read it? :-)

Will do.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.