[Bug 76828] [next] TpClientFactory should be the top level singleton

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76828

--- Comment #13 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #11)
>  - "McdMaster: take a TpClientFactory at construct-time": priv->factory
> should be unref in dispose instead of priv->dbus_daemon.

priv->client_factory was already unreffed in dispose.

The fact that priv->dbus_daemon changed from "owned ref" to "borrowed ref" in
this commit means I should have removed the tp_clear_object
(&priv->dbus_daemon) that was also in dispose. I didn't (but perhaps a refleak
elsewhere cancelled out this error, or perhaps I missed the crash because it
was only after testing had completed). However, I'm not going to bother
rebasing to fix that (unless you insist), since we've deleted TpDBusDaemon
anyway.

I agree that in general "owned ref" is a better pattern.

While checking that the endpoint of next-factory2 didn't have any crashes
during testing, I did find that the test build of MC was crashing during
shutdown for an unrelated reason. With that fixed (patch in a moment), it isn't
crashing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.