[Bug 76828] [next] TpClientFactory should be the top level singleton

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76828

--- Comment #19 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to comment #18)
> (In reply to comment #8)
> > Added one more commit:
> > http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/commit/
> > ?h=factory&id=09505790cfbcc97e0f4cc51b720d6dc7684bd2f9
> 
> I applied this, but then reverted it, because it removes dup_*_features()
> functions which are certainly useful (even if subclassing isn't).

We don't need dup_*_features() vfuncs, factory subclasses can call
_add_*_features() just fine. AFAIK, those vfunc are there to not return
TpTextChannel specific features when getting the features of a TpCallChannel.
But I don't think that's an issue, TpProxy will filter features that it doesn't
know, I think.

> I think I'm going to do a whole-stack test *without* this patch, then think
> about which parts of it make sense to pull in.

fair enough.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.