[Bug 76828] [next] TpClientFactory should be the top level singleton

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76828

Xavier Claessens <xclaesse at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

--- Comment #23 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to comment #22)
> (In reply to comment #21)
> > Not tested yet, but compiles and passes "make check":
> > http://cgit.freedesktop.org/~smcv/empathy/log/?h=next-factory

 -
http://cgit.freedesktop.org/~smcv/empathy/commit/?h=next-factory&id=7a735da21f170d75808cf32899c5322e116cc34a:
You can use g_application_get_dbus_connection() instead of g_bus_get_sync().
You can also use HasNameOwner. Checking on my ubuntu 14.04, unity takes
"org.gnome.Shell" name probably for some compat. So that empathy checks seems
wrong, but that's not a regression from your branch.

 -
http://cgit.freedesktop.org/~smcv/empathy/commit/?h=next-factory&id=77f6895f743fd0d5d9fad7dafb327bee3753486b:
the factory singleton is leaked then in empathy_init(). Wondering how that was
working before, because it does unref the AM... Maybe empathy_factory_dup()
should set itself as default if tp_client_factory_can_set_default() is true?

> Reviewed, added attachment #96775 [details] [review], no changes in response
> to review, please check:
> http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log/?h=next-
> factory2

+1 for the whole branch.

> Unreviewed:
> http://cgit.freedesktop.org/~smcv/telepathy-idle/log/?h=next-factory
+1
> http://cgit.freedesktop.org/~smcv/telepathy-rakia/log/?h=next-factory
+1
> http://cgit.freedesktop.org/~smcv/telepathy-salut/log/?h=next-factory

 -
http://cgit.freedesktop.org/~smcv/telepathy-salut/commit/?h=next-factory&id=7b7810b5f295b4d769f96b695b2e1eae82c6b476:
why do you init in each test instead of once in main?

> http://cgit.freedesktop.org/~smcv/telepathy-gabble/log/?h=next-factory
+1
> http://cgit.freedesktop.org/~smcv/telepathy-account-widgets/log/?h=next-
> factory
+1
> http://cgit.freedesktop.org/~smcv/folks/log/?h=next-factory
+1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.