[Bug 76369] [next] Remove dbus-glib GTypes from public API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76369

--- Comment #8 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #1)
> I've reviewed header files, but not signals or properties yet

I think the top priorities are the client side:

> tp_capabilities_get_channel_classes returns a{sv}s.
> TpCapabilities:channel-classes is the same.

I started on this but it's pretty annoying, because the regression test is all
in terms of dbus-glib.

> tp_connection_manager_param_get_default has a parallel GVariant version
> already, so it can probably be deleted.
> 
> TpDBusPropertiesMixin is entirely dbus-glib-based.
> 
> Unrelated, but handle.h should talk about entity types, not handle types.
> 
> tp_message_set takes a GValue.

> tp_account_get_avatar_finish() returns a GArray<guchar> which is OK but a
> bit odd. I might replace it with GBytes?

(In reply to comment #2)
> Properties and signals:

> TpAccount:connection-error-details is an a{sv}. TpAccount::status-changed
> contains the same.

This was easy, I have a patch already.

> TpCapabilities:channel-classes (but it also has channel-classes-variant)
> 
> TpChannelDispatchOperation:cdo-properties
> 
> TpChannel:channel-properties
> 
> TpChannel::group-members-changed (the details)

> TpObserveChannelContext:observer-info
> 
> TpTextChannel:message-types (would be OK with a different GType)

> TpAccountRequest:avatar is a GArray of undocumented type (by inspection:
> GArray<guchar>, which is a bit weird and a GBytes would probably be better).

> TpHandleChannelContext:dbus-context (etc.) should probably be OBJECT rather
> than POINTER now.
> 
> TpProtocol:avatar-requirements should be BOXED rather than POINTER?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.