[Bug 77188] New: [next] Remove dbus-glib GTypes from public API: TpSvc* signals

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77188

          Priority: medium
            Bug ID: 77188
                CC: guillaume.desmottes at collabora.co.uk,
                    xclaesse at gmail.com
          Assignee: telepathy-bugs at lists.freedesktop.org
            Blocks: 68661, 76369
           Summary: [next] Remove dbus-glib GTypes from public API: TpSvc*
                    signals
        QA Contact: telepathy-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: simon.mcvittie at collabora.co.uk
          Hardware: Other
            Status: NEW
           Version: git master
         Component: tp-glib
           Product: Telepathy

+++ This bug was initially created as a clone of Bug #76369 +++

We should make sure that dbus-glib isn't exposed in our high-level API. One
thing we can do is to stop TpSvc* interfaces from emitting signals.

Here are the signals that were mandated by dbus-glib and are also used as
GObject signals:

---- potentially emitted by base classes ----

> Connection (all CMs):
>     "status-changed",

Used just about everywhere; needs special-casing

> Channel (all CMs):
>     "closed",

Used extensively, special case needed

>     "content-added",
>     "content-removed",
>     "call-state-changed",

Used in Gabble, special case probably needed

> TLSCertificate (potentially all CMs):
>     "accepted",
>     "rejected",

Used in Gabble and Haze. We could emit normal signals adjacent to these.

---- only emitted by CM/MC code ----

> Account (MC): "removed"
> ChannelDispatcher/CDO/CR (MC):
>     "finished",
>     "failed",
>     "succeeded",

Those are actively used in MC. We could turn them into normal signals and emit
them adjacent to tp_svc_foo_emit_bar().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.