[Bug 77144] [next] implement properties per-interface, not monolithically

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77144

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #5)
>  - "TpCapabilities: operate in terms of GVariant": Is the DEBUG in
> tp_capabilities_set_property() still desired? Doesn't hurt I guess.

*shrug* I'll leave it in for now.

>  - tp_connection_manager_param_dup_default_variant() could be renamed to
> _get_default_variant() if it uses a variant internally as well. Shouldn't be
> a lot to change afaik.

The policy I'm following at the moment (yes, I know I haven't been 100%
consistent about this) is "if it doesn't need renaming, don't rename it". The
time for gratuitous renaming has passed, IMO.

OTOH, if a function is breaking API anyway, *then* I rename.

>  - tp_message_set_variant() could be renamed to tp_message_set()

Likewise.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.