[Bug 77189] [next] make TpBaseConnection GVariant-based

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77189

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
Sorry, make that:
http://cgit.freedesktop.org/~smcv/telepathy-glib/log/?h=gdbus-object2

I'm happy with your commits in that branch if you're OK with my commits in the
same branch :-)

I fixed a few minor things I noticed while reviewing.

One things I'm less sure about:

+ _tp_gdbus_connection_set_self_handle (self->priv->connection_skeleton,
+ self->priv->self_handle);
+ _tp_gdbus_connection_set_self_id (self->priv->connection_skeleton,
+ self->priv->self_id);

This could use g_object_set() like I did, or freeze + thaw notifications, so it
wouldn't emit two separate PropertiesChanged signals (although arguably we
should change the spec XML so it doesn't emit any at all).

We should probably go through the spec and classify our interfaces into "could
use PropertiesChanged", "needs some properties marked as 'invalidates'", "not
suitable for PropertiesChanged", then add appropriate annotations (and maybe
even delete some unnecessary signals).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.