[Bug 77189] [next] make TpBaseConnection GVariant-based

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Apr 16 08:32:11 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=77189

--- Comment #15 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
(In reply to comment #14)
> Instead of having that static assert everywhere, I would just put it just
> next to the TpHandle typedef. We are never going to make TpHandle anything
> else than 32 bits.

TpHandle is already not guaranteed to be 32-bit. It's a guint, not a guint32,
because that was dbus-glib's API.

If you want to *change* TpHandle to a guint32 in Tp1, we could do that... then
if the static assertion fails on some platform (which is unlikely, tbh), we
have to be very careful at the telepathy-glib <-> dbus-glib boundary, which is
non-type-safe.

That's probably the best approach despite the lack of type-safety - we're
trying to eradicate GArray<guint> from our API in any case, and the static
assertion will at least give us some early-warning.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list