[Bug 77189] [next] make TpBaseConnection GVariant-based

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Apr 16 09:33:18 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=77189

--- Comment #19 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to comment #12)
> > +   * If the channel implementation uses
> > +   * <link linkend="telepathy-glib-dbus-properties-mixin">TpDBusPropertiesMixin</link>,
> > +   * this property can implemented using
> > +   * tp_dbus_properties_mixin_make_properties_hash() as follows:
> 
> Hmm, this is interesting. That won't necessarily work any more once you have
> switched the channel to be a GDBusObjectSkeleton, because not all the
> properties will necessarily be TpDBusPropertiesMixin-mediated...
> 
> I think we'll need a vfunc that fills a GVariantDict, and a note that
> overriding the vfunc is a better way to do things than overriding the
> property.
> 
> We can cross that bridge when we come to it, though.

I have WIP code here that makes TpDBusPropertiesMixin's getters return GVariant
and tp_dbus_properties_mixin_make_properties_hash() takes a GVariantDict, as
does TpBaseChannel::fill_immutable_properties(). Did not get to the point where
it all builds though. Stay tuned.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list