[Bug 77189] [next] make TpBaseConnection GVariant-based

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=77189

--- Comment #29 from Xavier Claessens <xclaesse at gmail.com> ---
(In reply to comment #26)
> http://cgit.freedesktop.org/~smcv/telepathy-glib/log?h=gdbus-object
> (all commits since next - there's more than one page, but some of them are
> yours)

 - 0b57d9e66ca25a5e6684751a23a88b91e719e3c6 can be removed since it's replaced
by 22ed228270e7e29e7ede985a198d5c675464be51

 - I have to admit I'm totally lost with TpDBusPropertiesMixin. We never
implement TpSvcDBusProperties anymore, right? So
_tp_dbus_connection_gather_tp_svc_skeletons() could warn if it sees that iface?
We could use the "invisible mixin" in all CMs to kill
tp_dbus_properties_mixin_class_init() and all code paths where offset!=0? I'm
happier now that it is in -dbus because it should really be considered
deprecated and we should try to remove it completely from all CMs on the long
term.

 - tbh, I don't really like TpPreseceMixin using qdata to find the skeleton, I
was happy to remove that kind of hack from TpBaseContactList. But if you prefer
that way, I've no strong argument to stop you from doing it. Note that the
TpBaseConnectionPrivate struct can move back to the .c instead of -internal.h
now if you want.

This is a huge step forward, thanks !

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.