[Bug 23148] Telepathy 1.0: break D-Bus API to remove deprecated stuff (metabug)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=23148

--- Comment #35 from Simon McVittie <simon.mcvittie at collabora.co.uk> ---
  * Returns: a TplEntity instance with identifier, alias and
  * avatar's token copied. Type parameter is useful to differentiate between
- * normal contact and self contact, thus only %TPL_ENTITY_CONTACT and
- * %TPL_ENTITY_SELF are accepted. If contact is %NULL, an entity of type
- * %TPL_ENTITY_UNKNOWN with id set to "unknown" is returned.
+ * normal contact and self contact, thus only %TP_ENTITY_TYPE_CONTACT and
+ * %TP_ENTITY_TYPE_SELF are accepted. If contact is %NULL, an entity of type
+ * %TP_ENTITY_TYPE_NONE with id set to "unknown" is returned.
  */
 TplEntity *
 tpl_entity_new_from_tp_contact (TpContact *contact,
- TplEntityType type)
+ TpEntityType type)

Should tpl_entity_new_from_tp_contact (NULL, TP_ENTITY_TYPE_NONE) also be
accepted? At the moment it'll trip a g_return_val_if_fail. Please either allow
that combination (but not (non-NULL, NONE)), or add something like this to the
doc-comment:

  If @contact is %NULL, an entity of type %TP_ENTITY_TYPE_NONE is returned,
  with @id set to "unknown". (Note that it is not valid to call this function
  with @type set to %TP_ENTITY_TYPE_NONE.)

Other than that, all looks good.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.