[Bug 75204] [next] remove TpAsv from public API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=75204

--- Comment #7 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #2)
> First 4 look good.

Merged those already.

> This is undefined behaviour. You're returning a pointer to stack contents
> which are no longer guaranteed not to be scribbled on after this function
> returns.

Good point. I added a !fixup commit.

(In reply to comment #3)
> > base-client: remove not vardict filter API
> >
> > take_*_filter() are still used to implement the vardict API for now so they
> > are now static.
> 
> Please replace /** with /* when you make public functions static.

Done. I changed only those who are still static, not the one I turned to a
static function as an intermediary step to make commits smaller but which are
finally removed.

(In reply to comment #5)
> + * When constructing a new object, #TpAccountChannelRequest:request
> + * must be set to a non-%NULL value, and the other must remain unspecified.
> 
> The part after the second comma can go away now :-)

Fixed.

> I don't think you should do much (any?) more than this in telepathy-glib
> without catching up in API users, particularly MC, Empathy, and Empathy's
> account widgets submodule.

I pushed a few extra tube channels patches but yeah I'm going to start porting
things now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.