[Bug 75204] [next] remove TpAsv from public API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=75204

--- Comment #26 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #22)
> Maybe this should be (guint32) TP_ENTITY_TYPE_CONTACT for obvious
> correctness.

done.

(In reply to comment #23)
> tp-fs example: use tp_base_client_add_handler_filter_vardict()
> 
> Is it deliberate that this example no longer catches video-only calls, and
> more seriously, no longer tells CMs to make us video-callable?

It's not; fixed.

(In reply to comment #24)
> remove tp_connection_get_detailed_error()
> 
> @@ -235,11 +235,13 @@ test_unregistered_error (Test *test,
> 
> + str = tp_connection_dup_detailed_error_vardict (test->conn, NULL);
> + g_assert_cmpstr (str, ==, "net.example.WTF");
> + g_free (str);
> + str = tp_connection_dup_detailed_error_vardict (test->conn, &asv);
> + g_assert_cmpstr (str, ==, "net.example.WTF");
>   g_assert (asv != NULL);
> + g_variant_unref (asv);
> 
> The second time, str is leaked.

Fixed.

I merged a rebased version with all the fixup merged.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.