[Bug 55107] GVariant-based Handler_Info

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55107

--- Comment #6 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> ---
(In reply to comment #4)
> Comment on attachment 94880 [details] [review]
> handle-channel-context: replace get_handler_info by a GVariant version
> 
> Review of attachment 94880 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: telepathy-glib/handle-channel-context.c
> @@ +690,3 @@
> >  {
> >    g_return_val_if_fail (TP_IS_HANDLE_CHANNELS_CONTEXT (self), NULL);
> > +  return tp_asv_to_vardict (self->handler_info);
> 
> Contrary to Bug #55109, this relies for its correctness on tp_asv_to_vardict
> *not* returning a floating ref. Pick one :-)

I rebased the branch on top of next where tp_asv_to_vardict() now returns a
floating ref so it's now ok.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.